chore: implement phase 9 - #2787
Draft
Tofel wants to merge 2 commits into
Draft
Conversation
📊 API Diff Results
|
Tofel
force-pushed
the
dx-5122-alerts-assertion-p9
branch
2 times, most recently
from
September 1, 2026 14:18
99e5355 to
95381e3
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p9
branch
from
September 1, 2026 14:46
95381e3 to
04ba08e
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p9
branch
2 times, most recently
from
September 2, 2026 09:45
267665d to
7d9cc1e
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p9
branch
from
September 2, 2026 09:57
7d9cc1e to
effe464
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p9
branch
from
September 2, 2026 11:05
effe464 to
ce02d17
Compare
Tofel
force-pushed
the
dx-5122-alerts-assertion-p9
branch
from
September 4, 2026 15:03
c91c98f to
1377467
Compare
Invariant defended: H5/H7. The one question: can check report a pass over a window it did not prove? Check() is the I/O shell around the pure decide(). Single-step synthesizes the header and its own sentinel, so no mode flag reaches the pure layer. Log mode stops the recorder before the one full read. The header, not a definition re-resolved after the window closed, is the authority for what was paused when the window opened — it decides `skipped`, the drain set, and the transitionGrace max. The flock, not the pidfile, is the authority for whether a writer still exists.
Tofel
force-pushed
the
dx-5122-alerts-assertion-p9
branch
from
September 4, 2026 15:15
1377467 to
f659144
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
Check(), the I/O shell around puredecide()(invariants H5/H7). Single-step mode synthesizes the header and its own sentinel, so no mode flag reaches the pure layer; log mode stops the recorder before the one full read. The header (not a re-resolved definition) decidesskipped, the drain set, andtransitionGrace; the flock (not the pidfile) is the authority for whether a writer still exists.Review focus:
check.gomode handling, and the header-vs-flock authority decisions.